Skip to content

feat: applicant name search#5974

Open
emilyjablonski wants to merge 10 commits intomainfrom
5665/applicant-name-search
Open

feat: applicant name search#5974
emilyjablonski wants to merge 10 commits intomainfrom
5665/applicant-name-search

Conversation

@emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Feb 28, 2026

This PR addresses #5665

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Adds a search by first and last primary applicant name to an advocate's applications page.

How Can This Be Tested/Reviewed?

Sign in as the existing advocate@example.com which is pre-seeded with multiple applications.

  • Should only search with a minimum of 3 characters
  • Should debounce
  • Should only appear for advocates

Expected differences from the design:

  • Shorter placeholder text
  • Subnote about character length
  • Full width
  • No icon
  • Including the primary applicants name under the listing name
  • (Any unrelated differences like w status are out of scope)

Design:
Screenshot 2026-02-27 at 8 31 04 PM
Implementation:
Screenshot 2026-02-27 at 8 31 58 PM

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@netlify
Copy link

netlify bot commented Feb 28, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit 905bc6a
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/69a32d148141e4000865b518
😎 Deploy Preview https://deploy-preview-5974--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 28, 2026

Deploy Preview for bloom-angelopolis ready!

Name Link
🔨 Latest commit 905bc6a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/69a32d14acbe3d00082409c5
😎 Deploy Preview https://deploy-preview-5974--bloom-angelopolis.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 28, 2026

Deploy Preview for bloom-public-seeds ready!

Name Link
🔨 Latest commit 905bc6a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-public-seeds/deploys/69a32d14f6d63f00084fe355
😎 Deploy Preview https://deploy-preview-5974--bloom-public-seeds.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Feb 28, 2026

Deploy Preview for partners-bloom-msq2 canceled.

Name Link
🔨 Latest commit 905bc6a
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-msq2/deploys/69a32d14282ffd00085b0820

@netlify
Copy link

netlify bot commented Feb 28, 2026

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 905bc6a
🔍 Latest deploy log https://app.netlify.com/projects/bloom-exygy-dev/deploys/69a32d14e2e3f80008c048d5
😎 Deploy Preview https://deploy-preview-5974--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

const whereClause = this.buildWhereClause(params);
const normalizedParams = {
...params,
userId: user.id,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: Reminder to self to check in

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: These perm tests were sometimes flaky because of not mocking cron job creates, so added this mock to all these tests

@emilyjablonski emilyjablonski marked this pull request as ready for review February 28, 2026 19:20
@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 review needed Requires 1 more review before ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant